fit: enable a11y eslint rules #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
Kyzyl-ool
reviewed
Feb 12, 2024
| @@ -59,6 +60,8 @@ export const Save = ({ | |||
|
|
|||
| return ( | |||
| <div | |||
There was a problem hiding this comment.
if this div has a button role, can it be a tag ?
Kyzyl-ool
reviewed
Feb 12, 2024
src/components/Search/Search.tsx
Outdated
| @@ -78,7 +78,8 @@ export const Search = ({ | |||
| }; | |||
|
|
|||
| return ( | |||
| <div className={b('input-icon')} onClick={handleClick}> | |||
| // eslint-disable-next-line jsx-a11y/click-events-have-key-events | |||
| <div role="button" tabIndex={0} className={b('input-icon')} onClick={handleClick}> | |||
There was a problem hiding this comment.
also here, can we use tag instead of div?
NikitaCG
changed the title
Kyzyl-ool
reviewed
Feb 15, 2024
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable jsx-a11y/click-events-have-key-events */ | |||
There was a problem hiding this comment.
This comment is not necessary, as you using onclick for button tag, bot for div
Kyzyl-ool
reviewed
Feb 15, 2024
src/components/Search/Search.tsx
Outdated
| @@ -78,9 +78,10 @@ export const Search = ({ | |||
| }; | |||
|
|
|||
| return ( | |||
| <div className={b('input-icon')} onClick={handleClick}> | |||
| // eslint-disable-next-line jsx-a11y/click-events-have-key-events | |||
Kyzyl-ool
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #167