Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-655 #2670

Merged
merged 10 commits into from
Dec 21, 2023
Merged

NET-655 #2670

merged 10 commits into from
Dec 21, 2023

Conversation

uGiFarukh
Copy link
Contributor

@uGiFarukh uGiFarukh commented Nov 16, 2023

Describe your changes

  • Updated the HostPull model with extra structures for mqtt fallback goroutine on client side.

Related to -> gravitl/netclient#628

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

* Updated HostPull structure to include EgressRoutes and FirewallUpdate models.
* added ServerVersion structure to hostpull model
* removed ServerVersion structure
@uGiFarukh uGiFarukh added the enhancement New feature or request label Nov 16, 2023
@uGiFarukh uGiFarukh self-assigned this Nov 16, 2023
@uGiFarukh uGiFarukh mentioned this pull request Nov 16, 2023
8 tasks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the changes to set these fields under the pull handler??

@abhishek9686 abhishek9686 merged commit 1f9ef50 into develop Dec 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants