Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-671 #630

Merged
merged 2 commits into from
Nov 22, 2023
Merged

NET-671 #630

merged 2 commits into from
Nov 22, 2023

Conversation

uGiFarukh
Copy link
Contributor

@uGiFarukh uGiFarukh commented Nov 13, 2023 •
edited
Loading

Describe your changes

  • Fixed windows netclient egress routes add

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

  1. Create an egress gateway using another linux machine under the same netmaker network.
  2. Add a windows netclient with this PR branch to any netmaker network.
  3. Test from the windows netclient if those egress ranges are reachable through the windows netclient.
  4. Repeat the same steps and verify for ipv6 network and ipv6 windows netclient.

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

@uGiFarukh
NET-671
55cbd61 
* Fixed windows netclient egress routes add
@uGiFarukh uGiFarukh added bug Something isn't working Fixed Fixed labels Nov 13, 2023
@uGiFarukh uGiFarukh self-assigned this Nov 13, 2023
abhishek9686
abhishek9686 requested changes Nov 13, 2023
View reviewed changes
wireguard/wireguard_windows.go Outdated
mask,
addr.IP.String())
cmd := fmt.Sprintf("netsh int ipv4 add route %s interface=%s nexthop=%s store=%s",
addr.Network.String(), ncutils.GetInterfaceName(), "0.0.0.0", "active")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle ipv6 route setting as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ipv6 support added

@uGiFarukh
windows support for ipv6 egress range
f28b6b5 
* windows support for ipv6 egress ranges
@abhishek9686 abhishek9686 merged commit 1222c55 into develop Nov 22, 2023
20 checks passed
@uGiFarukh uGiFarukh mentioned this pull request Nov 27, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishek9686 abhishek9686 abhishek9686 approved these changes

@Aceix Aceix Awaiting requested review from Aceix

@theguy951357 theguy951357 Awaiting requested review from theguy951357

@gabrielseibel1 gabrielseibel1 Awaiting requested review from gabrielseibel1

@pwilson77 pwilson77 Awaiting requested review from pwilson77

@afeiszli afeiszli Awaiting requested review from afeiszli

@mattkasun mattkasun Awaiting requested review from mattkasun

Assignees

@uGiFarukh uGiFarukh

Labels
bug Something isn't working Fixed Fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uGiFarukh @abhishek9686