NET-642 #621
Merged
NET-642 #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uGiFarukh
requested review from
Aceix,
gabrielseibel1,
pwilson77,
afeiszli,
abhishek9686 and
mattkasun
* Unused variables and types cleanup on types.go
* hardcoded url for windows binary changed
abhishek9686
reviewed
Nov 3, 2023
functions/use_version.go
Outdated
| @@ -102,6 +100,19 @@ func versionLessThan(v1, v2 string) (bool, error) { | |||
|
|
|||
| // UseVersion switches the current netclient version to the one specified if available in the github releases page | |||
| func UseVersion(version string, rebootDaemon bool) error { | |||
| // Use Windows specific version change process | |||
| if runtime.GOOS == "windows" { | |||
| windowsBinaryURL := fmt.Sprintf("https://github.com/gravitl/netclient/releases/download/%s/netclient-%s-%s", version, runtime.GOOS, runtime.GOARCH) | |||
There was a problem hiding this comment.
missing .exe in the filename
* url typo fix
theguy951357
approved these changes
Nov 4, 2023
abhishek9686
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Provide Issue ticket number if applicable/not in title
Provide link to Netmaker PR if required
Provide testing steps
Checklist before requesting a review