Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-595 #592

Merged
merged 1 commit into from
Oct 4, 2023
Merged

NET-595 #592

merged 1 commit into from
Oct 4, 2023

Conversation

uGiFarukh
Copy link
Contributor

@uGiFarukh uGiFarukh commented Sep 21, 2023

Describe your changes

  • Stun on network change. Restarting the netclient daemon if a network changes to perform new udp hole punch.

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

  1. Join a netclient to a network with other hosts.
  2. Make sure the host do not have static endpoint enabled.
  3. Take note of the current endpoint IP address.
  4. Switch the netclient host internet network to a different one. (From wifi or cable to cellular data)
  5. After the internet network switch, new endpoint IP address should get updated on the UI and also wireguard connections from other hosts to the network changed host in the same netmaker network should work fine.
  6. Need to perform some lengthy time chaos testing on this to make sure netclient daemon restart on connection lost is not messing with any other functionalities.

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

* Stun on network change. Restarting the netclient daemon if a network changes to perform new udp hole punch.
@uGiFarukh uGiFarukh added bug Something isn't working Fixed Fixed labels Sep 21, 2023
@uGiFarukh uGiFarukh self-assigned this Sep 21, 2023
functions/daemon.go Show resolved Hide resolved
@abhishek9686 abhishek9686 merged commit 322a27d into develop Oct 4, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed Fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants