Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NET-416): bug with nc-gui register on windows #504

Merged
merged 3 commits into from
Jul 20, 2023
Merged

fix(NET-416): bug with nc-gui register on windows #504

merged 3 commits into from
Jul 20, 2023

Conversation

Aceix
Copy link
Contributor

@Aceix Aceix commented Jul 17, 2023 •
edited
Loading

Describe your changes

Provide Issue ticket number if applicable/not in title

https://toil.kitemaker.co/cQARgD-Gravitl/6a50SD-Netmaker/items/416

Provide link to Netmaker PR if required

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

@Aceix Aceix marked this pull request as ready for review July 17, 2023 14:28
@Aceix Aceix merged commit 1f77373 into develop Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkasun mattkasun mattkasun approved these changes

@abhishek9686 abhishek9686 abhishek9686 approved these changes

@theguy951357 theguy951357 Awaiting requested review from theguy951357

@gabrielseibel1 gabrielseibel1 Awaiting requested review from gabrielseibel1

@afeiszli afeiszli Awaiting requested review from afeiszli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aceix @abhishek9686 @mattkasun