Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NET-381] Reduce log level of a msg from Error to Warn #478

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

gabrielseibel1
Copy link
Contributor

Describe your changes

I reduced log level of a msg from Error to Warn because it was appearing too frequently and it was not actually indicating a problematic situation.

Provide link to Netmaker PR if required

Provide testing steps

Run netclient joining a network
Observe "failed to check for endpoint on peer" is not printed frequently.

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2023

CLA assistant check
All committers have signed the CLA.

functions/mqhandlers.go Outdated Show resolved Hide resolved
@afeiszli afeiszli merged commit 6f39622 into develop Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants