Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NET-347): deduce public endpoint on daemon start #474

Merged
merged 9 commits into from
Jun 27, 2023

Conversation

Aceix
Copy link
Contributor

@Aceix Aceix commented Jun 23, 2023

Describe your changes

Details here

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

@Aceix Aceix marked this pull request as ready for review June 23, 2023 12:37
functions/daemon.go Show resolved Hide resolved
nmproxy/stun/stun.go Outdated Show resolved Hide resolved
functions/daemon.go Outdated Show resolved Hide resolved
functions/daemon.go Outdated Show resolved Hide resolved
functions/daemon.go Outdated Show resolved Hide resolved
- use in-memory config to chech
- increase log level
Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing steps pass
critical list passes

@abhishek9686 abhishek9686 merged commit ed4b141 into develop Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants