Revert "[backport v8] force http2 kubernetes #9294" #9953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NajiObeid How long will it take to fix this issue? If it's just a day or two it might make more sense to tell customers to just roll back to 8.1.0 instead of rolling out a revert and then the fix a few days later. What do you think? I think a revert makes more sense if something is going to take a week+ to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9796
Issue reported today about not being able to use with the http2 change I introduced
kubectl execIt turns out spdy doesn't play well with http2 and I naively thought the connection would downgrade to http1.
I also thought I tested this case.
There has been works to deprecate spdy in kubernetes but nothing concrete at the moment.
kubernetes/kubernetes#7452
kubernetes/kubernetes#89163
I won't revert the change to master as of right now as I would like to try a couple more things.