Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8] backport #9697 (improved Google OIDC) #9926

Merged
merged 13 commits into from
Jan 27, 2022

Conversation

espadolini
Copy link
Contributor

@espadolini
Copy link
Contributor Author

Like #9697, I will wait for approvals here and for gravitational/teleport.e#387, I will merge e and I will update the e-ref commit to point to that before merging this one.

@espadolini espadolini force-pushed the espadolini/v8-google-cloudidentity branch from 6bde786 to 0432b53 Compare January 26, 2022 14:14
@Tener
Copy link
Contributor

Tener commented Jan 26, 2022

So, this looks to be a rather involved change (387 files, multiple dependencies) with the potential for unexpected issues. I'm not saying anything is particularly wrong, but perhaps we want to avoid backporting it to keep v8 stable?

@espadolini
Copy link
Contributor Author

@Tener v8 still has the vendor directory, that's where the vast majority of those changes come from; do you want me to split off that part of the PR into a separate module upgrade instead?

@Tener
Copy link
Contributor

Tener commented Jan 26, 2022

@espadolini Nah, no need to split; I agree that the plain number of changed files may be a wrong metric to look at directly given that includes vendor/*. I was more concerned about the possibility of introducing bugs to an otherwise stable branch, but seeing that @russjones have approved, I'm guessing this wasn't a valid concern after all.

@russjones russjones requested review from rosstimothy and ibeckermayer and removed request for Tener and nklaassen January 27, 2022 17:38
go get: upgraded cloud.google.com/go v0.60.0 => v0.100.2
go get: upgraded github.com/golang/snappy v0.0.1 => v0.0.3
go get: upgraded github.com/googleapis/gax-go/v2 v2.0.5 => v2.1.1
go get: upgraded go.opencensus.io v0.22.5 => v0.23.0
go get: upgraded golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d => v0.0.0-20211104180415-d3ed0bb246c8
go get: upgraded golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1 => v0.0.0-20211216021012-1d35b9e2eb4e
go get: upgraded google.golang.org/api v0.29.0 => v0.65.0
go get: upgraded google.golang.org/genproto v0.0.0-20210602131652-f16073e35f0c => v0.0.0-20220107163113-42d7afdf6368
go get: upgraded google.golang.org/protobuf v1.26.0 => v1.27.1
This undoes the user account impersonation changes, and always requires
an admin account again.
This also removes the extra boolean flag that was added previously.
Enterprise builds will break unless gravitational/teleport.e#387
is included.
@espadolini espadolini force-pushed the espadolini/v8-google-cloudidentity branch from 0432b53 to abc91dc Compare January 27, 2022 18:20
@espadolini espadolini enabled auto-merge (squash) January 27, 2022 18:20
auto-merge was automatically disabled January 27, 2022 20:30

Pull Request is not mergeable

@espadolini espadolini enabled auto-merge (squash) January 27, 2022 21:27
@espadolini espadolini merged commit ac83ad4 into branch/v8 Jan 27, 2022
@espadolini espadolini deleted the espadolini/v8-google-cloudidentity branch January 27, 2022 22:53
@webvictim webvictim mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants