-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8] backport #9697 (improved Google OIDC) #9926
Conversation
Like #9697, I will wait for approvals here and for gravitational/teleport.e#387, I will merge |
6bde786
to
0432b53
Compare
So, this looks to be a rather involved change (387 files, multiple dependencies) with the potential for unexpected issues. I'm not saying anything is particularly wrong, but perhaps we want to avoid backporting it to keep v8 stable? |
@Tener v8 still has the vendor directory, that's where the vast majority of those changes come from; do you want me to split off that part of the PR into a separate module upgrade instead? |
@espadolini Nah, no need to split; I agree that the plain number of changed files may be a wrong metric to look at directly given that includes vendor/*. I was more concerned about the possibility of introducing bugs to an otherwise stable branch, but seeing that @russjones have approved, I'm guessing this wasn't a valid concern after all. |
go get: upgraded cloud.google.com/go v0.60.0 => v0.100.2 go get: upgraded github.com/golang/snappy v0.0.1 => v0.0.3 go get: upgraded github.com/googleapis/gax-go/v2 v2.0.5 => v2.1.1 go get: upgraded go.opencensus.io v0.22.5 => v0.23.0 go get: upgraded golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d => v0.0.0-20211104180415-d3ed0bb246c8 go get: upgraded golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1 => v0.0.0-20211216021012-1d35b9e2eb4e go get: upgraded google.golang.org/api v0.29.0 => v0.65.0 go get: upgraded google.golang.org/genproto v0.0.0-20210602131652-f16073e35f0c => v0.0.0-20220107163113-42d7afdf6368 go get: upgraded google.golang.org/protobuf v1.26.0 => v1.27.1
This undoes the user account impersonation changes, and always requires an admin account again.
This also removes the extra boolean flag that was added previously.
Enterprise builds will break unless gravitational/teleport.e#387 is included.
0432b53
to
abc91dc
Compare
Backport of