-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the cert.create
event
#9822
Conversation
@espadolini Can you provide an example of what the event looks like, in particular the subject field? |
Updated the PR description. |
4db171d
to
ac80782
Compare
certs.user.emit
eventuser.cert.create
event
@espadolini I think we should break up the Subject into fields on the event. Users have to parse it right now and it's going to just get harder as we add support for Windows. Plus, even if we say something like it's comma separated, that will be what users expect forever and we'll be stuck with it even if it doesn't work for us in the future. Also, what do you think about making it |
I did it this way because I intended it to be more for security audit/postmortem situations rather than general event consumption. Should we replicate every field that goes into a
Yeah, that's probably better. |
ac80782
to
ff1c1e1
Compare
@espadolini Let's change |
ff1c1e1
to
1de2ca1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@espadolini, please push changes after reviews to new commits, so it's easier to what changed in relation to the last round.
Sorry about that, I tend to just amend commits if they're almost completely rewritten - I'll be more mindful about it in the future. |
No worries. In an ideal world GitHub would be more helpful in showing diffs. Or maybe I'm just bad at GitHub? 🤷 |
@espadolini Looks good to me, but make sure you make the webapps changes so this event shows up in the UI. Feel free to merge this into |
For now, this is only emitted for user certificate issuance.
c669167
to
bd7f327
Compare
* Add the `cert.create` event For now, this is only emitted for user certificate issuance. * Make `cert_type` a string rather than an enum * Match field names and json tags in events.Identity * Change events.Identity.Traits to be a wrappers.LabelValues/wrappers.Traits * Event code shouldn't be under T10xx anymore
* Add the `cert.create` event For now, this is only emitted for user certificate issuance. * Make `cert_type` a string rather than an enum * Match field names and json tags in events.Identity * Change events.Identity.Traits to be a wrappers.LabelValues/wrappers.Traits * Event code shouldn't be under T10xx anymore
* Add the `cert.create` event For now, this is only emitted for user certificate issuance. * Make `cert_type` a string rather than an enum * Match field names and json tags in events.Identity * Change events.Identity.Traits to be a wrappers.LabelValues/wrappers.Traits * Event code shouldn't be under T10xx anymore
* Add the `cert.create` event For now, this is only emitted for user certificate issuance. * Make `cert_type` a string rather than an enum * Match field names and json tags in events.Identity * Change events.Identity.Traits to be a wrappers.LabelValues/wrappers.Traits * Event code shouldn't be under T10xx anymore
* Add the `cert.create` event For now, this is only emitted for user certificate issuance. * Make `cert_type` a string rather than an enum * Match field names and json tags in events.Identity * Change events.Identity.Traits to be a wrappers.LabelValues/wrappers.Traits * Event code shouldn't be under T10xx anymore
* Add the `cert.create` event For now, this is only emitted for user certificate issuance. * Make `cert_type` a string rather than an enum * Match field names and json tags in events.Identity * Change events.Identity.Traits to be a wrappers.LabelValues/wrappers.Traits * Event code shouldn't be under T10xx anymore
* Add the `cert.create` event For now, this is only emitted for user certificate issuance. * Make `cert_type` a string rather than an enum * Match field names and json tags in events.Identity * Change events.Identity.Traits to be a wrappers.LabelValues/wrappers.Traits * Event code shouldn't be under T10xx anymore
This adds an event that's emitted whenever an auth server issues a certificate (or a set of certificates, like the SSH+TLS pair that is issued to users). The event is only emitted on user cert generation for now.
Sample events:
Local login
OIDC login
OIDC login after assuming a role through an access request
Fixes half of TEL-Q321-7.
Closes #9591.