helm: Add logging configuration to teleport-kube-agent chart #9632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whitespace after `type:` was being trimmed, which was causing a lint error. Not sure how this got through the linter in the first place.
webvictim
changed the title
ptgott
reviewed
Jan 4, 2022
Remove shell prompt character
ptgott
approved these changes
Jan 5, 2022
|
@r0mant Could I get a stamp on this one too please? |
russjones
approved these changes
Jan 15, 2022
russjones
approved these changes
Jan 15, 2022
webvictim
added a commit
that referenced
this pull request
Jan 17, 2022
* [helm] Re-add space after type in service definition (#9503) The whitespace after `type:` was being trimmed, which was causing a lint error. Not sure how this got through the linter in the first place. * helm: Adds log configuration to teleport-kube-agent chart * Remove erroneous value * Update reference.mdx Remove shell prompt character
webvictim
added a commit
that referenced
this pull request
Jan 26, 2022
…9814) * [helm] Re-add space after type in service definition (#9503) The whitespace after `type:` was being trimmed, which was causing a lint error. Not sure how this got through the linter in the first place. * helm: Adds log configuration to teleport-kube-agent chart * Remove erroneous value * Update reference.mdx Remove shell prompt character
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR largely copies #9130 to also add
logconfiguration to theteleport-kube-agentchart.auditLogMirrorToStdoutis not needed here, as changes toaudit_events_urionly apply to the Teleport auth server (which is handled by theteleport-clusterchart)Thanks to @pimguilherme for the original PR and idea - tagging here as I believe he also requested this PR be created.
Also cherry-picks #9503 to
masteras it only applied tobranch/v8previously and was causing a lint error.Backports required:
branch/v8