Replace cluster periodics with watchers #9609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/remove_cluster_periodics
branch
2 times, most recently
from
f5d5c7f to
0ad9b7b
Compare
rosstimothy
added
scale
rosstimothy
force-pushed
the
tross/remove_cluster_periodics
branch
from
0ad9b7b to
32e9a28
Compare
zmb3
reviewed
Jan 4, 2022
greedy52
reviewed
Jan 4, 2022
rosstimothy
force-pushed
the
tross/remove_cluster_periodics
branch
2 times, most recently
from
6b69282 to
2dbdd96
Compare
greedy52
approved these changes
Jan 6, 2022
| } | ||
| newHost = make(map[string]types.CertAuthority, len(host)) | ||
| for _, ca := range host { | ||
| newHost[ca.GetName()] = ca |
There was a problem hiding this comment.
nit: ca.GetID() may also be a good option for keys. I think in that case you only need one map too. not big deal. and hopefully when generics come, it will make these conversions easier
rosstimothy
force-pushed
the
tross/remove_cluster_periodics
branch
from
2dbdd96 to
fdc2603
Compare
|
@rosstimothy @fspmarshall I know that locks have different states they can be in with respect to availability. Does this take that into consideration? |
The |
rosstimothy
force-pushed
the
tross/remove_cluster_periodics
branch
from
fdc2603 to
3de91da
Compare
rosstimothy
force-pushed
the
tross/remove_cluster_periodics
branch
from
e8470de to
b77c080
Compare
zmb3
approved these changes
Jan 19, 2022
Remove periodically sending locks and certificate authorities to leaf clusters. Instead we can rely on the watcher system to only deliver resources to leaf clusters when changes occur. Fixes #8817
…otateTrustedClusters test.
…thorityWatcher test.
… Filter is opt-in by default
rosstimothy
force-pushed
the
tross/remove_cluster_periodics
branch
from
b77c080 to
0d381dc
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove periodically sending locks and certificate authorities to leaf clusters. Instead
we can rely on the watcher system to only deliver resources to leaf clusters when changes occur.
Fixes #8817