-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access request locks #9478
Merged
Merged
Access request locks #9478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
reviewed
Dec 17, 2021
espadolini
force-pushed
the
espadolini/access-request-locks
branch
from
December 20, 2021 15:29
fb06466
to
209be8d
Compare
espadolini
changed the base branch from
master
to
espadolini/tls-access-requests
December 20, 2021 15:57
espadolini
force-pushed
the
espadolini/tls-access-requests
branch
from
December 22, 2021 15:43
9230a68
to
14b945c
Compare
espadolini
force-pushed
the
espadolini/access-request-locks
branch
from
December 22, 2021 15:43
209be8d
to
6a76765
Compare
espadolini
force-pushed
the
espadolini/tls-access-requests
branch
from
December 22, 2021 17:08
14b945c
to
c3fc400
Compare
espadolini
force-pushed
the
espadolini/access-request-locks
branch
from
December 22, 2021 17:09
6a76765
to
a2c0cb1
Compare
@espadolini Can you update the PR description with details on CLI UX? Can you also update documentation (you can do that in another ticket) https://goteleport.com/docs/access-controls/guides/locking/ |
espadolini
force-pushed
the
espadolini/tls-access-requests
branch
from
December 28, 2021 16:35
c3fc400
to
85c9b02
Compare
espadolini
force-pushed
the
espadolini/access-request-locks
branch
from
December 28, 2021 17:50
89b4fa3
to
84537ee
Compare
espadolini
changed the base branch from
espadolini/tls-access-requests
to
master
December 28, 2021 17:51
espadolini
changed the base branch from
master
to
espadolini/tls-access-requests
December 28, 2021 19:43
espadolini
force-pushed
the
espadolini/tls-access-requests
branch
2 times, most recently
from
December 30, 2021 10:16
fec96d7
to
cc3d2a7
Compare
espadolini
force-pushed
the
espadolini/access-request-locks
branch
from
December 30, 2021 10:18
84537ee
to
42c415e
Compare
espadolini
force-pushed
the
espadolini/tls-access-requests
branch
from
December 30, 2021 16:44
cc3d2a7
to
52ca4fd
Compare
espadolini
force-pushed
the
espadolini/access-request-locks
branch
from
December 30, 2021 16:44
38b0df5
to
1fde7d7
Compare
espadolini
force-pushed
the
espadolini/tls-access-requests
branch
from
December 31, 2021 10:32
52ca4fd
to
f363105
Compare
espadolini
force-pushed
the
espadolini/access-request-locks
branch
from
December 31, 2021 10:34
1fde7d7
to
f71e3f5
Compare
espadolini
force-pushed
the
espadolini/tls-access-requests
branch
3 times, most recently
from
January 3, 2022 11:26
14170d9
to
696a154
Compare
espadolini
force-pushed
the
espadolini/access-request-locks
branch
from
January 3, 2022 14:27
f71e3f5
to
692784d
Compare
espadolini
force-pushed
the
espadolini/access-request-locks
branch
from
January 20, 2022 19:04
572dde0
to
5c99384
Compare
espadolini
force-pushed
the
espadolini/access-request-locks
branch
from
January 24, 2022 12:26
5c99384
to
c8eec54
Compare
fspmarshall
approved these changes
Jan 24, 2022
lxea
approved these changes
Jan 24, 2022
espadolini
force-pushed
the
espadolini/access-request-locks
branch
from
January 24, 2022 18:59
c8eec54
to
42ca5b5
Compare
This only contains the internal part, no user-visible changes
espadolini
force-pushed
the
espadolini/access-request-locks
branch
from
January 24, 2022 19:18
42ca5b5
to
b6ea7a2
Compare
This was referenced Jan 25, 2022
espadolini
added a commit
that referenced
this pull request
Jan 25, 2022
* Add access request locks This only contains the internal part, no user-visible changes * Add a `tctl lock` flag to specify an access request ID * Tests for access request locks
espadolini
added a commit
that referenced
this pull request
Jan 25, 2022
* Add access request locks This only contains the internal part, no user-visible changes * Add a `tctl lock` flag to specify an access request ID * Tests for access request locks
espadolini
added a commit
that referenced
this pull request
Jan 26, 2022
* Add access request locks This only contains the internal part, no user-visible changes * Add a `tctl lock` flag to specify an access request ID * Tests for access request locks
espadolini
added a commit
that referenced
this pull request
Jan 26, 2022
espadolini
added a commit
that referenced
this pull request
Jan 27, 2022
* Add access request locks This only contains the internal part, no user-visible changes * Add a `tctl lock` flag to specify an access request ID * Tests for access request locks
espadolini
added a commit
that referenced
this pull request
Jan 27, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to add a lock on a specific access request; when such a lock is in force, any identity that has used that access request is prevented from interacting with the system - the user can however switch to a less privileged certificate, or log out and log back in again and regain their own regular access.
While it would be sufficient to lock the user out if malicious behavior was suspected, this helps in the case where elevated privileges are requested and granted by mistake; the request can be blocked and the user can then continue working with their own static roles (or with the roles granted by other access requests).
The
types.LockTarget
type will gain a newAccessRequest
field, following the nomenclature ofAccessRequests
/access_requests
already in use in thesession.start
event.As locks are currently only supported on the tool side by
tctl
, the only addition to the UX is a new flag totctl lock
that matches the field name in
types.LockTarget
(converted tokebab-case
as the other CLI options are).Such a lock serialized as yaml (as output by
tctl get locks
ortctl get lock/<lockname>
) looks likeFixes TEL-Q321-3.
Docs PR: