Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] Fix app server goroutine leak #9459

Merged
merged 2 commits into from
Dec 17, 2021
Merged

[v8] Fix app server goroutine leak #9459

merged 2 commits into from
Dec 17, 2021

Conversation

jimbishopp
Copy link
Contributor

Backport #9332

@jimbishopp
Fix app server goroutine leak (#9332)
d5b97e7 
Fixes gravitational/teleport-private#79
LAT-APP21-4: DOS - Goroutine leak in app server

Prevent the app server's HandleConnection from blocking for 
every connection until the server closes. This change blocks 
only until the connection is closed.
@github-actions github-actions bot requested review from lxea and timothyb89 December 16, 2021 19:34
@jimbishopp jimbishopp enabled auto-merge (squash) December 16, 2021 20:29
@jimbishopp jimbishopp requested review from greedy52 and jakule and removed request for timothyb89 and lxea December 16, 2021 22:33
@codingllama
Copy link
Contributor

Will review shortly, but meanwhile could you set a title/description similar to the original? We should be able to check the branch logs and know what this is about without referring to external sources.

@jimbishopp jimbishopp changed the title Backport LAT-APP21-4 Fix app server goroutine leak Dec 17, 2021
@jimbishopp
Copy link
Contributor Author

jimbishopp commented Dec 17, 2021 •
edited
Loading

Will review shortly, but meanwhile could you set a title/description similar to the original? We should be able to check the branch logs and know what this is about without referring to external sources.

Done. The auto-merge commit has the same information as the original as well.

@jimbishopp jimbishopp changed the title Fix app server goroutine leak [v8] Fix app server goroutine leak Dec 17, 2021
@jimbishopp jimbishopp disabled auto-merge December 17, 2021 16:01
@jimbishopp jimbishopp enabled auto-merge (squash) December 17, 2021 16:01
@jimbishopp jimbishopp merged commit d1f8fa2 into branch/v8 Dec 17, 2021
@jimbishopp jimbishopp deleted the jim/v8/lat-app21-4 branch December 17, 2021 16:51
@webvictim webvictim mentioned this pull request Mar 4, 2022
Closed
@alexatcanva alexatcanva mentioned this pull request Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakule jakule jakule approved these changes

@codingllama codingllama codingllama approved these changes

@greedy52 greedy52 greedy52 approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimbishopp @codingllama @greedy52 @jakule