Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about wildcard certificates #9454

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Dec 16, 2021

Guides to getting started with Teleport on various platforms
recommend creating a DNS record for *.teleport.com. It would help
prospective users to know why this is needed. This change adds
context for why Application Access requires a wildcard subdomain.

Fixes #5378

@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch from cf5ec8c to d463dbd Compare December 16, 2021 17:48
@github-actions github-actions bot requested a review from klizhentas December 16, 2021 17:48
@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch from d463dbd to bf10176 Compare December 20, 2021 17:08
@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch from bf10176 to aa85ee9 Compare January 4, 2022 21:52
@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch from aa85ee9 to 43afe5f Compare January 18, 2022 20:09
@ptgott ptgott requested a review from xinding33 January 18, 2022 21:14
@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch 3 times, most recently from de89404 to 600d423 Compare January 24, 2022 18:05
@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch from 600d423 to 1265f03 Compare February 4, 2022 19:21
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether or not we agree with them, many organizations still see the requirement for a wildcard certificate as less secure or harder to obtain.

It would be nice if we could find a way to suggest wildcard certificates for their ease of use without scaring away folks who don't want to use wildcards.

- We will assume your Teleport cluster is accessible at `teleport.example.com` and `*.teleport.example.com`. Configured DNS records are required to automatically fetch a [Let's Encrypt](https://letsencrypt.org) certificate.

<Admonition type="note" title="Teleport and Wildcard Certificates">
Teleport assigns a subdomain to each application you have configured for Application Access (e.g., `grafana.teleport.example.com`), so you need to create a DNS A record with a wildcard subdomain (e.g., `*.teleport.example.com`). This way, Let's Encrypt can issue a wildcard certificate, enabling clients to verify your Teleport hosts regardless of the application they are accessing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't necessarily need a wildcard certificate, this is just the quickest and easiest solution.

Can we word this in such a way to at least suggest that the alternative of requesting only the subdomains you plan to put behind app access is possible?

@@ -41,6 +45,10 @@ using Let's Encrypt [ACME](https://letsencrypt.org/how-it-works/) protocol.
We will assume that you have configured DNS records for `teleport.example.com`
and `*.teleport.example.com` to point to the Teleport node.

<Admonition type="note" title="Why do I need a wildcard certificate?">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an include? I would think so, given it's copied several times.

@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch from 1265f03 to 4f04e02 Compare February 9, 2022 23:14
@ptgott ptgott requested a review from zmb3 February 9, 2022 23:17
@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch 2 times, most recently from 0cc6199 to fd584ec Compare February 14, 2022 20:09
@@ -131,8 +133,7 @@ for web apps using [application access](../../application-access/introduction.md

# Create a JSON file changeset for AWS.
$ jq -n --arg ip ${MYIP?} --arg dns ${MYDNS?} '{"Comment": "Create records", "Changes": [
{"Action": "CREATE", "ResourceRecordSet": {"Name": $dns, "Type": "A", "TTL": 300, "ResourceRecords": [{ "Value": $ip}]}},
{"Action": "CREATE", "ResourceRecordSet": {"Name": ("*." + $dns), "Type": "A", "TTL": 300, "ResourceRecords": [{ "Value": $ip}]}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why are we removing the commands for creating wildcard records? If we do that, it is no longer a copy-pasteable example :) Same below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point—I've restored the original commands while adding a reminder to adjust them for your environment in case, say, a user doesn't want to create a wildcard record.

@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch 2 times, most recently from 2ea8f54 to 2713841 Compare February 16, 2022 18:20
@ptgott ptgott requested a review from r0mant February 16, 2022 18:20
@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch 2 times, most recently from e8b4f71 to 075784b Compare February 24, 2022 20:57
@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch from 075784b to dc685be Compare March 2, 2022 22:00
@ptgott
Copy link
Contributor Author

ptgott commented Mar 2, 2022

@r0mant Would you have time to give this one another look? Thanks!

@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch from dc685be to 9ae8b12 Compare March 9, 2022 20:41
@ptgott
Copy link
Contributor Author

ptgott commented Mar 9, 2022

@zmb3 @r0mant I fixed a lot of conflicts while rebasing this one, so there may be changes to the original commits that require a second look.

@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch 3 times, most recently from a903a90 to c1bb9db Compare March 14, 2022 21:20
@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch from c1bb9db to 36ba8b9 Compare March 16, 2022 20:47
ptgott added 3 commits March 18, 2022 14:02
Guides to getting started with Teleport on various platforms
recommend creating a DNS record for *.teleport.com. It would help
prospective users to know why this is needed. This change adds
context for why Application Access requires a wildcard subdomain.

Fixes #5378
- Move information into a partial
- Mention that you can create a DNS A record for each application-
  specific subdomain
@ptgott ptgott force-pushed the paul.gottschling/wildcards-5378 branch from 36ba8b9 to 67d4b5d Compare March 18, 2022 18:14
@ptgott ptgott enabled auto-merge (squash) March 18, 2022 18:15
@ptgott ptgott merged commit 0aa6855 into master Mar 18, 2022
@ptgott ptgott deleted the paul.gottschling/wildcards-5378 branch March 18, 2022 18:19
ptgott added a commit that referenced this pull request Mar 21, 2022
Backports #9454

* Add notes about wildcard certificates

Guides to getting started with Teleport on various platforms
recommend creating a DNS record for *.teleport.com. It would help
prospective users to know why this is needed. This change adds
context for why Application Access requires a wildcard subdomain.

Fixes #5378

* Respond to PR feedback

- Move information into a partial
- Mention that you can create a DNS A record for each application-
  specific subdomain

* Restore DNS-related cloud provider commands
ptgott added a commit that referenced this pull request Mar 21, 2022
Backports #9454

* Add notes about wildcard certificates

Guides to getting started with Teleport on various platforms
recommend creating a DNS record for *.teleport.com. It would help
prospective users to know why this is needed. This change adds
context for why Application Access requires a wildcard subdomain.

Fixes #5378

* Respond to PR feedback

- Move information into a partial
- Mention that you can create a DNS A record for each application-
  specific subdomain

* Restore DNS-related cloud provider commands
ptgott added a commit that referenced this pull request Mar 21, 2022
Backports #9454

* Add notes about wildcard certificates

Guides to getting started with Teleport on various platforms
recommend creating a DNS record for *.teleport.com. It would help
prospective users to know why this is needed. This change adds
context for why Application Access requires a wildcard subdomain.

Fixes #5378

* Respond to PR feedback

- Move information into a partial
- Mention that you can create a DNS A record for each application-
  specific subdomain

* Restore DNS-related cloud provider commands
ptgott added a commit that referenced this pull request Mar 22, 2022
Backports #9454

* Add notes about wildcard certificates

Guides to getting started with Teleport on various platforms
recommend creating a DNS record for *.teleport.com. It would help
prospective users to know why this is needed. This change adds
context for why Application Access requires a wildcard subdomain.

Fixes #5378

* Respond to PR feedback

- Move information into a partial
- Mention that you can create a DNS A record for each application-
  specific subdomain

* Restore DNS-related cloud provider commands
ptgott added a commit that referenced this pull request Mar 22, 2022
Backports #9454

* Add notes about wildcard certificates

Guides to getting started with Teleport on various platforms
recommend creating a DNS record for *.teleport.com. It would help
prospective users to know why this is needed. This change adds
context for why Application Access requires a wildcard subdomain.

Fixes #5378

* Respond to PR feedback

- Move information into a partial
- Mention that you can create a DNS A record for each application-
  specific subdomain

* Restore DNS-related cloud provider commands
ptgott added a commit that referenced this pull request Mar 22, 2022
Backports #9454

* Add notes about wildcard certificates

Guides to getting started with Teleport on various platforms
recommend creating a DNS record for *.teleport.com. It would help
prospective users to know why this is needed. This change adds
context for why Application Access requires a wildcard subdomain.

Fixes #5378

* Respond to PR feedback

- Move information into a partial
- Mention that you can create a DNS A record for each application-
  specific subdomain

* Restore DNS-related cloud provider commands
ptgott added a commit that referenced this pull request Mar 22, 2022
Backports #9454

* Add notes about wildcard certificates

Guides to getting started with Teleport on various platforms
recommend creating a DNS record for *.teleport.com. It would help
prospective users to know why this is needed. This change adds
context for why Application Access requires a wildcard subdomain.

Fixes #5378

* Respond to PR feedback

- Move information into a partial
- Mention that you can create a DNS A record for each application-
  specific subdomain

* Restore DNS-related cloud provider commands
ptgott added a commit that referenced this pull request Mar 22, 2022
Backports #9454

* Add notes about wildcard certificates

Guides to getting started with Teleport on various platforms
recommend creating a DNS record for *.teleport.com. It would help
prospective users to know why this is needed. This change adds
context for why Application Access requires a wildcard subdomain.

Fixes #5378

* Respond to PR feedback

- Move information into a partial
- Mention that you can create a DNS A record for each application-
  specific subdomain

* Restore DNS-related cloud provider commands
ptgott added a commit that referenced this pull request Mar 22, 2022
Backports #9454

* Add notes about wildcard certificates

Guides to getting started with Teleport on various platforms
recommend creating a DNS record for *.teleport.com. It would help
prospective users to know why this is needed. This change adds
context for why Application Access requires a wildcard subdomain.

Fixes #5378

* Respond to PR feedback

- Move information into a partial
- Mention that you can create a DNS A record for each application-
  specific subdomain

* Restore DNS-related cloud provider commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quickstart Guide Lets Encrypt Section Provides WildCard Cert Example Without Explanation
4 participants