-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back to "/" when home directory doesn't exist for tsh ssh
#9413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add test coverage?
Note that assuming This is probably okay for now, but eventually we'll be running teleport as a Windows service, so could we at least add a |
@atburke Can you backport this to |
@gabrielcorado Can you review this when you have a moment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not getting it reviewed sooner.
without home directory will be disconnected how to resolve it |
This PR changes
tsh ssh
's behavior when a user's$HOME
points to a non-existent directory. Previously, this caused the command to fail; now, the user's home directory is set to/
(this is the same behavior as OpenSSH).Fixes #2834.