(v8) Do not parse MySQL server packets #9411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
requested review from
timothyb89
and removed request for
atburke,
rosstimothy and
quinqu
smallinsky
approved these changes
Dec 15, 2021
r0mant
force-pushed
the
roman/v8/fixmysql
branch
from
31e0bcf to
a70d016
Compare
gabrielcorado
approved these changes
Dec 15, 2021
This was referenced Dec 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9406.
Previously all packets sent by MySQL client or server were parsed by the same
ParsePacketfunction. This caused issues with some packets returned by the server. For example, our parsing code could get confused by a certain packet returned by server if it's "type" (5th byte in packet) would match one of client-side packets. This led to the issue where one of the result set packets returned by server was mistakenly interpreted as aCOM_CHANGE_USERpacket. This PR addressed it by not trying to interpret the server packets since we don't do any processing for them currently.