Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split dev tools into a seperate docker container #9410

Merged
merged 7 commits into from
Dec 15, 2021
Merged

Conversation

xacrimon
Copy link
Contributor

@xacrimon xacrimon commented Dec 14, 2021

This PR adds "devbox", a container for running tools similar to buildbox but targeting fast image builds and support for alternate architectures like arm64. This vastly speeds up and improves the reliability of workflows on ARM64 laptops such as those that are Apple Silicon based. For now, this devbox is only used for make grpc as it is an immediate need. In the future, more tools should be moved to use devbox for local workflows.

@russjones russjones requested review from r0mant and removed request for jakule December 15, 2021 19:40
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this locally, make grpc works like a charm now 👍

@xacrimon xacrimon enabled auto-merge (squash) December 15, 2021 19:53
@xacrimon xacrimon merged commit 7951de5 into master Dec 15, 2021
@xacrimon xacrimon deleted the joel/devbox-grpc branch December 15, 2021 20:11
@rosstimothy
Copy link
Contributor

This doesn't work for me on an intel mac.

The dev-box image tries to pull https://storage.googleapis.com/golang/go1.17.2.linux-x86_64.tar.gz which doesn't exist.
The correct url is https://storage.googleapis.com/golang/go1.17.2.linux-amd64.tar.gz

 => CACHED [4/7] RUN apt-get update -y --fix-missing &&     apt-get -q -y upgrade &&     apt-get install -q -y --no-install-recommends         curl         build-essential         ca-certificates         unzip         clang-10         clang-format-10         locales         git &&     dpkg-reconfigure locales &&     apt-get -y clean &&     rm -rf /var/lib/apt/lists/*                                              0.0s
 => ERROR [5/7] RUN mkdir -p /opt && cd /opt && curl https://storage.googleapis.com/golang/go1.17.2.linux-x86_64.tar.gz | tar -xz &&     mkdir -p /go/src/github.com/gravitational/teleport &&     chmod a+w /go &&     chmod a+w /var/lib &&     chmod a-w /                                                                                                                                                                  0.4s
------                                                                                                                                                                                                                                                                                                                                                                                                                              
 > importing cache manifest from teleport-devbox:                                                                                                                                                                                                                                                                                                                                                                                   
------                                                                                                                                                                                                                                                                                                                                                                                                                              
------
 > [5/7] RUN mkdir -p /opt && cd /opt && curl https://storage.googleapis.com/golang/go1.17.2.linux-x86_64.tar.gz | tar -xz &&     mkdir -p /go/src/github.com/gravitational/teleport &&     chmod a+w /go &&     chmod a+w /var/lib &&     chmod a-w /:
#9 0.187   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
#9 0.187                                  Dload  Upload   Total   Spent    Left  Speed
100   197  100   197    0     0    947      0 --:--:-- --:--:-- --:--:--   942
#9 0.399 
#9 0.399 gzip: stdin: not in gzip format
#9 0.400 tar: Child returned status 1
#9 0.400 tar: Error is not recoverable: exiting now
------
executor failed running [/bin/sh -c mkdir -p /opt && cd

@xacrimon xacrimon mentioned this pull request Dec 16, 2021
xacrimon added a commit that referenced this pull request Dec 17, 2021
* Allow a configurable event TTL in DynamoDB (#8840)

* Split dev tools into a seperate docker container (#9410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants