Fix NO_PROXY addr logic #9287
Merged
Fix NO_PROXY addr logic #9287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
reviewed
Dec 8, 2021
rosstimothy
approved these changes
Dec 8, 2021
gabrielcorado
approved these changes
Dec 9, 2021
|
It looks like you are covered in the reviewer department, so silently sitting this one out. @quinqu, I think the bot is assigning a new set of reviewers when the PR moves from "draft" to "ready to review". FYI. |
r0mant
approved these changes
Dec 15, 2021
smallinsky
force-pushed
the
smallinsky/fix_no_proxy_logic
branch
from
94f4a28 to
76c9a29
Compare
smallinsky
added a commit
that referenced
this pull request
Dec 15, 2021
smallinsky
added a commit
that referenced
this pull request
Dec 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix #9191
The
addrenv passed toproxy.DialerFromEnvironmentis not actual remote address (addrcontains cluster name ) thus theNO_PROXYenv variable is not correctly respected.Switch from
addrto actual remote proxy addresst.ProxyAddr