Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid "Entering/Leaving directory" output in Make #9246

Merged
merged 4 commits into from
Dec 9, 2021

Conversation

justinas
Copy link
Contributor

@justinas justinas commented Dec 6, 2021

GNU Make 4.3 prints messages such as Entering directory: foo to stdout, resulting in garbage output in .drone.yml:

environment:
  RUNTIME: |-
    make[1]: Entering directory '/home/justinas/gravitational/teleport/build.assets'
    go1.17.2
    make[1]: Leaving directory '/home/justinas/gravitational/teleport/build.assets'

This might've been overlooked if code with this change (introduced in 6808d6a) has only been tested with something like BSD Make, which may behave differently in this case.

This uses the -s ("silent") flag to suppress such messages. There is an alternative --no-print-directory option, but it seems non-portable as it does not exist in BSD Make.

@github-actions github-actions bot requested review from r0mant and russjones December 6, 2021 14:19
@justinas justinas marked this pull request as ready for review December 6, 2021 14:47
@justinas justinas force-pushed the justinas/fix-dronegen-version-output branch from 928cb8d to fce1d3b Compare December 6, 2021 15:38
@justinas justinas enabled auto-merge (squash) December 6, 2021 15:48
@russjones russjones self-requested a review December 9, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants