Add --cluster flag to all tsh db subcommands, Add "--diag_addr" flag to teleport db/app start
#9220
Conversation
greedy52
requested review from
r0mant,
jimbishopp,
jakule,
Joerger and
smallinsky
| if clusterName == "" || clusterName == p.Cluster { | ||
| return p.Databases, nil | ||
| } |
There was a problem hiding this comment.
Is this special case needed? Maybe we can just get rid of p.Databases field completely since profile now has a method for returning databases for the specified cluster?
There was a problem hiding this comment.
I just found that tsh logut is using calling dbprofile.Delete on each of profile.Databases
I can certainly change this to use the new function. But this is a problem if we have logined db from another cluster, then we are not calling dbprofile.Delete on dbs in other clusters.
i think this is an existing problem though
There was a problem hiding this comment.
Added issue #9250 for tracking the dbprofile.Delete problem
I found a few places where p.Databases are still used. Mainly when we looping through all profiles.
For example, in tsh logout, we are trying to get databases in each profile
Line 1131 in e938201
Similarly, we printStatus are all profiles and their databases (default cluster)
Line 2132 in e938201
I am debating to keep this special case for these scenarios for now. I think we can remove it once we decide what to do for the issue added above
| } | ||
|
|
||
| // addKey activates a new signed session key by adding it into the keystore. | ||
| func (a *LocalKeyAgent) addKey(key *Key) error { |
There was a problem hiding this comment.
Maybe we should pick a more explicative name?
Good catch @smallinsky! it's using profile's cluster. Let me fix and will test locally |
…/8653-8943-more-flags
…/8653-8943-more-flags
* Use t.Setenv in tests (#9154) This new feature in Go 1.17 automatically restores the environment variable to its previous value when a test ends, making it simpler to set up the environment for tests and less likely that we accidentally leave behind global state. Also convert some of the remaining uses of check to standard Go tests. * use shorter temp dir for socket path Co-authored-by: Zac Bergquist <[email protected]> Also ported a fix from #9220 to use short path for unix path in key_agent.test
…lag to `teleport db/app start` (#9220) * add diag to teleport db/app start * db --cluster flag supports * add some ut and fix issue ~/.tsh get removed during test * working mongodb * fix logout * fix ut * code review comment * fix mysql
closes #8653 #8943
Changes
--diag_addrtoteleport db/app start--clusterflag to alltsh dbsubcommandstsh db login/ls" to show--cluster ` in corresponding section, if cluster flag is definedcf.HomePathshould be used instead of"", forStatusCurrentandSaveProfilecallsTesting
Setup
Tested
tsh dbsubcommands works as expected--clusterflagtsh sshworks as its is