Bring back previous u2f challenge response for web terminal #8830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlisa
requested review from
alex-kovoy,
r0mant and
russjones
as code owners
codingllama
approved these changes
Nov 2, 2021
russjones
reviewed
Nov 2, 2021
| // Get the common challenge fields from the first item. | ||
| // All of these fields should be identical for all u2fChals. | ||
| Challenge: u2fChals[0].Challenge, | ||
| AppID: u2fChals[0].AppID, |
There was a problem hiding this comment.
Will this indexing always pass? Can you ever get empty u2fChals?
There was a problem hiding this comment.
yes it will always pass b/c we do a length check before we enter this switch case: https://github.com/gravitational/teleport/blob/master/lib/web/terminal.go#L352
kimlisa
added a commit
that referenced
this pull request
Nov 3, 2021
kimlisa
added a commit
that referenced
this pull request
Nov 3, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression bug, where firefox still requires global
appIdandchallenge, unlike Chrome where it looks for it among theu2f_challengeslist. I could've handled this in the client side by doing the same thing as we did here, but decided to keep the previous functionality