Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v8] Remove checking for error from session end in web terminal (#8797) #8816

Merged
merged 1 commit into from
Nov 2, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions lib/web/terminal.go
Original file line number Diff line number Diff line change
@@ -494,16 +494,6 @@ func (t *TerminalHandler) streamTerminal(ws *websocket.Conn, tc *client.Teleport
return
}

// Check if remote process exited with error code, eg: RemoteCommandFailure (255).
if t.sshSession != nil {
if err := t.sshSession.Wait(); err != nil {
if exitErr, ok := err.(*ssh.ExitError); ok {
t.log.Warnf("Remote shell exited with error code: %v", exitErr.ExitStatus())
return
}
}
}

// Send close envelope to web terminal upon exit without an error.
envelope := &Envelope{
Version: defaults.WebsocketVersion,