[firestore] Set the cursor to empty when the end is reached #7448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
approved these changes
Jul 2, 2021
Comment on lines
+506
to
+507
| // This solution here seems to be the the most common but I haven't been able to find | ||
| // any documented hard guarantees on firestore not early returning for some reason like response |
There was a problem hiding this comment.
Took a peek at the source code of firestore.DocumentItarator. Looks like GetAll() is just a convenience wrapper around Next(), which collects all results until iterator.Done reached. Since the docs guarantee that Next() only returns iterator.Done if there are actually no more documents matching the query, I think we can treat this as effectively guaranteed.
nklaassen
approved these changes
Jul 2, 2021
xacrimon
added a commit
that referenced
this pull request
Jul 9, 2021
* nil firestore cursor on end * added explainer
xacrimon
added a commit
that referenced
this pull request
Jul 9, 2021
* nil firestore cursor on end * added explainer
xacrimon
added a commit
that referenced
this pull request
Jul 9, 2021
xacrimon
added a commit
that referenced
this pull request
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pagination contract now requires that the cursor is set to empty once the end of a query is reached. Previously we didn't run all tests in CI and it worked somewhat wierd so I had to resort to running tests manually and switching them around which was not very reliable nor good. Firestore CI recently got fixed and this enables the rest of the tests to now run correctly. This PR makes sure the cursor is set to empty correctly once the end of the events have been reached. New UI changes rely on this behaviour.