Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API version generated file #7157

Merged
merged 9 commits into from
Jun 18, 2021
Merged

API version generated file #7157

merged 9 commits into from
Jun 18, 2021

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Jun 3, 2021

Since the Teleport version in teleport/version.go is not accessible inside teleport/api, this PR adds a generated version.go file to teleport/api.

This is needed for #7155 and #7118. It will also be necessary when the API is officially versioned and released.

Note: depending on the decided upon api versioning strategy, this generated file may end up having a different version than what's in teleport/version.go.

  • API versions might not be incremented with every Teleport release
  • API versions might become separate from the Teleport version
    • If this strategy is chosen, it may have some effects on Add V4 Roles #7118, so it would be ideal to decide on an API versioning strategy before Add V4 Roles #7118 is released. Otherwise, we should be able to backport a fix.

@Joerger Joerger requested a review from webvictim June 3, 2021 00:55
@Joerger Joerger requested a review from nklaassen June 3, 2021 00:55
@Joerger Joerger unassigned awly Jun 3, 2021
@Joerger Joerger requested review from andrejtokarcik, tcsc and awly June 3, 2021 00:56
@Joerger Joerger mentioned this pull request Jun 3, 2021
Makefile Show resolved Hide resolved
@Joerger Joerger requested a review from awly June 4, 2021 18:16
@nklaassen
Copy link
Contributor

#7118 has merged to master, can you update api/constants/constants.go and remove the temporary Version there, and api/metadata/metadata.go to use the generated value?

Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot.

@Joerger Joerger enabled auto-merge (squash) June 18, 2021 16:29
@Joerger Joerger merged commit a3aab98 into master Jun 18, 2021
@Joerger Joerger deleted the joerger/api-version-generation branch June 18, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants