Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RoleV3 to RoleV4 #7132

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Conversation

nklaassen
Copy link
Contributor

This PR renames RoleV3 and RoleSpecV3 to RoleV4 and RoleSpecV4, respectively. This was split out from #7118 to reduce noise, they will both be merged together.

Copy link
Contributor

@klizhentas klizhentas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change backwards-compatible? E.g. if I have an old client talking to new API returning V4, what would happen?

@nklaassen
Copy link
Contributor Author

Is this change backwards-compatible? E.g. if I have an old client talking to new API returning V4, what would happen?

This is a draft PR currently, I will be adding a description in #7118 and publishing that shortly. But basically yes, the server will return downgraded V3 roles to older clients

@nklaassen nklaassen mentioned this pull request Jun 1, 2021
@nklaassen nklaassen marked this pull request as ready for review June 2, 2021 01:14
@nklaassen nklaassen requested a review from tcsc June 2, 2021 01:14
@nklaassen nklaassen force-pushed the nklaassen/roles-v4-rename branch 6 times, most recently from 75eb8d4 to 7cfbdd7 Compare June 8, 2021 20:39
@nklaassen nklaassen force-pushed the nklaassen/roles-v4-rename branch 2 times, most recently from 5704a50 to c2fd072 Compare June 9, 2021 19:30
@nklaassen nklaassen force-pushed the nklaassen/roles-v4-rename branch from c2fd072 to 1fce63d Compare June 10, 2021 15:25
@nklaassen nklaassen merged commit 2ffebb1 into nklaassen/roles-v4 Jun 10, 2021
@nklaassen nklaassen deleted the nklaassen/roles-v4-rename branch June 10, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants