Add kubernetes_service option to teleport helm chart #5490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added kube to static token in case of kube_service def
stevenGravy
requested review from
awly,
r0mant,
russjones and
webvictim
as code owners
awly
reviewed
Feb 8, 2021
There was a problem hiding this comment.
@stevenGravy could you please test this with:
proxy_serviceenabled,kubernetes_servicenot enabledproxy_servicenot enabled,kubernetes_serviceenabled- both
proxy_serviceandkubernetes_serviceenabled - both
proxy_serviceandkubernetes_serviceenabled andproxy_service.kubernetes_public_addrset
klizhentas
approved these changes
Feb 8, 2021
Co-authored-by: Andrew Lytvynov <[email protected]>
Co-authored-by: Andrew Lytvynov <[email protected]>
Co-authored-by: Andrew Lytvynov <[email protected]>
|
@awly I confirmed all of the scenarios. Also reconfirmed with a optional |
awly
approved these changes
Feb 8, 2021
Joerger
pushed a commit
that referenced
this pull request
Feb 9, 2021
* Increment to version 0.0.10 * Add kubernetes_service option config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for using kubernetes_service option instead of kubernetes enabled under proxy. This allows for pointing at multiple other k8s clusters with a kubeconfig.