Fix windows cross-compilation with CGO #5485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install `mingw-w64` cross-compiler toolchain in the buildbox and pass magic flags to `go build` to use it.
awly
commented
Feb 4, 2021
| libsqlite3-0 \ | ||
| locales \ | ||
| make \ | ||
| mingw-w64 \ |
There was a problem hiding this comment.
Note to reviewers: this is the only new package added.
Everything else is formatting.
webvictim
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
LGTM. I tested the resulting tsh.exe on a Windows box and it worked as expected.
It's a shame that this will break straight cross-compiling on Linux (without the extra options) but given that we only build release binaries using Docker via Drone it isn't a huge issue.
Joerger
pushed a commit
that referenced
this pull request
Feb 9, 2021
Install `mingw-w64` cross-compiler toolchain in the buildbox and pass magic flags to `go build` to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install
mingw-w64cross-compiler toolchain in the buildbox and passmagic flags to
go buildto use it.Fixes
make -C build.assets release OS=windows.