[v17] fix: check if plugin type is identity center before SAML app and OIDC integration deletion #50360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttings is not nil for delete action
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
smallinsky
approved these changes
Dec 17, 2024
r0mant
approved these changes
Dec 17, 2024
public-teleport-github-review-bot
bot
removed request for
ravicious,
tcsc and
eriktate
|
We had tests to cover a case that covered identity center plugin exists and does not exist. This test is now updated to account for a case where other plugin simultaneously exist in Teleport e7a980a |
flyinghermit
deleted the
sshah/prevent-saml-app-and-integration-panic
branch
Merged
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #50359
changelog: Prevents panic in SAML app or OIDC integration deletion when a plugin type is not
PluginTypeAWSIdentityCenterorPluginAWSICSettingsis nil.