-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Vale warnings in three guides #50357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptgott
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v15
backport/branch/v16
backport/branch/v17
labels
Dec 17, 2024
github-actions
bot
requested review from
mmcallister,
r0mant,
xinding33 and
zmb3
December 17, 2024 19:29
🤖 Vercel preview here: https://docs-39sky845p-goteleport.vercel.app/docs |
mmcallister
approved these changes
Dec 17, 2024
ptgott
force-pushed
the
paul.gottschling/2024-12-17-vale
branch
from
December 18, 2024 19:14
01885a5
to
738cda1
Compare
🤖 Vercel preview here: https://docs-m6t18lbnq-goteleport.vercel.app/docs |
- Getting started guide for auto-discovering Kubernetes applications. - DynamoDB (as an application) guide. This change does not address one Vale warning with `tsh aws dymamodb`, which is a false positive. - Getting started guide for protecting applications.
ptgott
force-pushed
the
paul.gottschling/2024-12-17-vale
branch
from
December 24, 2024 13:58
738cda1
to
be6fff8
Compare
Amplify deployment status
|
zmb3
approved these changes
Dec 26, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant and
xinding33
December 26, 2024 17:59
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v15
backport/branch/v16
backport/branch/v17
documentation
no-changelog
Indicates that a PR does not require a changelog entry
size/sm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsh aws dymamodb
, which is a false positive.