[v16] Display warning if a user that wants to authorize a web session is not logged in Connect #50046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have the addon on v16.
gzdunek
added
the
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ravicious
approved these changes
Dec 11, 2024
ravicious
reviewed
Dec 11, 2024
Comment on lines
+124
to
+133
| <Link | ||
| css={` | ||
| cursor: pointer; | ||
| `} | ||
| onClick={() => { | ||
| ctx.commandLauncher.executeCommand('cluster-logout', { | ||
| clusterUri: rootCluster.uri, | ||
| }); | ||
| }} | ||
| > |
There was a problem hiding this comment.
This is not great, but <ButtonText> seems to be even worse. If we ever need to do something like this on master, it'd be a good idea to add some kind of inline prop to <ButtonText> that adds underline and removes font-size, color and min-height.
There was a problem hiding this comment.
Agree, I wasn't very happy doing it :(
avatus
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #49836 to branch/v16
I had to modify the warning to the old
AlertAPI. Also, we don't have the storybook control addon on v16, so I reverted the stories to the non-control version.