Use CMC as default config when set #50039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
added
the
no-changelog
hugoShaka
force-pushed
the
hugo/default-config-from-cmc
branch
from
faa086d to
20f0238
Compare
sclevine
approved these changes
Dec 10, 2024
Part of: [RFD-184](#47126) This commit implements backward compatibility when CMC is specified. After this PR, if the user has no `autoupdate_config` resource but a `cluster_maintenance_config` resource from RFD 109, we will use the CMC to generate the config (update hour and update days) and craft the `autoupdate_agent_rollout`.
hugoShaka
force-pushed
the
hugo/default-config-from-cmc
branch
from
20f0238 to
0b559ac
Compare
vapopov
approved these changes
Dec 13, 2024
bernardjkim
approved these changes
Dec 13, 2024
espadolini
approved these changes
Dec 13, 2024
public-teleport-github-review-bot
bot
removed the request for review
from strideynet
Co-authored-by: Edoardo Spadolini <[email protected]>
hugoShaka
force-pushed
the
hugo/default-config-from-cmc
branch
from
f062790 to
13f116d
Compare
hugoShaka
force-pushed
the
hugo/default-config-from-cmc
branch
from
13f116d to
c877658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: RFD-184
Goal (internal): https://github.com/gravitational/cloud/issues/10289
This PR implements backward compatibility when CMC is specified. After this PR, if the user has no
autoupdate_configresource but acluster_maintenance_configresource from RFD 109, we will use the CMC to generate the config (update hour and update days) and craft theautoupdate_agent_rollout.