Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic tctl commands for WorkloadIdentity resource kind #49828

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

strideynet
Copy link
Contributor

@strideynet strideynet commented Dec 5, 2024

Part of #49572

Depends on #49639

For now, the workload-identity family of commands is hidden. This is to avoid confusing anyone until the new UX is ready to be used by the wider population.


➜  scripts ./tctl-dev-leaf workload-identity ls
No workload identities configured
➜  scripts ./tctl-dev-leaf create ../workload_identity.yaml 
Workload identity "workload-identity" has been created
➜  scripts ./tctl-dev-leaf workload-identity ls            
Name              SPIFFE ID           
----------------- ------------------- 
workload-identity /foo/bar/{{ .Foo }} 
➜  scripts ./tctl-dev-leaf get workload_identity
kind: workload_identity
metadata:
  name: workload-identity
  revision: 4e5304c2-868d-4e96-92f1-93dc5b1e0ef2
spec:
  spiffe:
    id: /foo/bar/{{ .Foo }}
version: v1
➜  scripts ./tctl-dev-leaf get workload_identity/workload-identity
kind: workload_identity
metadata:
  name: workload-identity
  revision: 4e5304c2-868d-4e96-92f1-93dc5b1e0ef2
spec:
  spiffe:
    id: /foo/bar/{{ .Foo }}
version: v1
➜  scripts ./tctl-dev-leaf workload-identity rm workload-identity
Workload Identity "workload-identity" deleted successfully.
➜  scripts ./tctl-dev-leaf workload-identity ls
No workload identities configured

@strideynet strideynet force-pushed the strideynet/workload-identity-crud branch from be8e8b9 to 472b918 Compare December 9, 2024 09:47
@strideynet strideynet force-pushed the strideynet/tctl-support-workloadidentity branch from ae70dcf to 9f5a6d4 Compare December 9, 2024 11:03
@strideynet strideynet added backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry labels Dec 9, 2024
@strideynet strideynet marked this pull request as ready for review December 9, 2024 12:58
@github-actions github-actions bot added size/md tctl tctl - Teleport admin tool labels Dec 9, 2024
@github-actions github-actions bot requested review from avatus and vapopov December 9, 2024 12:58
@strideynet strideynet force-pushed the strideynet/workload-identity-crud branch from 9fb2f88 to 75e38b9 Compare December 9, 2024 15:22
Base automatically changed from strideynet/workload-identity-crud to master December 10, 2024 10:53
@strideynet strideynet force-pushed the strideynet/tctl-support-workloadidentity branch from fc753ee to e3a074d Compare December 10, 2024 13:10
@@ -0,0 +1 @@
Workload Identity "test" deleted successfully.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive never heard of this .golden file extension in my life. interesting to see it and all over the code base too

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from timothyb89 December 10, 2024 16:41
@strideynet strideynet added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@strideynet strideynet added this pull request to the merge queue Dec 10, 2024
Merged via the queue into master with commit 35e934c Dec 10, 2024
43 checks passed
@strideynet strideynet deleted the strideynet/tctl-support-workloadidentity branch December 10, 2024 17:38
@public-teleport-github-review-bot

@strideynet See the table below for backport results.

Branch Result
branch/v16 Failed
branch/v17 Create PR

strideynet added a commit that referenced this pull request Dec 10, 2024
* Add basic tctl commands for WorkloadIdentity resource kind

* Add `tctl workload-identity ls`

* Add `tctl workload-identity ls`

* Fix message strings to be consistent

* Add tests for `tctl workload-identity` functionality
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2024
…50029)

* Add basic tctl commands for WorkloadIdentity resource kind

* Add `tctl workload-identity ls`

* Add `tctl workload-identity ls`

* Fix message strings to be consistent

* Add tests for `tctl workload-identity` functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/md tctl tctl - Teleport admin tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants