Honor the proxy peering listen address specified in the configuration #49586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
added
backport/branch/v15
c-nbs
hugoShaka
approved these changes
Nov 29, 2024
zmb3
approved these changes
Nov 29, 2024
public-teleport-github-review-bot
bot
removed request for
tcsc,
avatus and
rosstimothy
|
@espadolini See the table below for backport results.
|
This was referenced Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation of proxy peering (in #12359) conflated the proxy peering listen address and the advertised proxy peering address; #14905 added a separate configuration option for the advertised address, but didn't change the fact that the Teleport initialization process still tried to guess at some plausible address to listen to.
This PR makes it so that the
peer_listen_addrspecified in the Teleport configuration file is actually used as the address we listen to, unmodified, and it's used as the basis to derive apeer_public_addrto advertise if needed.changelog: Fixed proxy peering listener not using the exact address specified in
peer_listen_addr