[v17] Machine ID: Add bitbucket join method for Bitbucket Pipelines joining (#48724)
#49335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng (#48724) * Add `bitbucket` join method for Bitbucket Pipelines joining This adds a new `bitbucket` join method that Machine ID bots can use to authenticate to Teleport from Bitbucket Pipelines CI runs. * Add unit tests for bitbucket joining This also fully adds `deployment_environment_uuid` which was found to be missing. * Fix imports * Update tf docs * Docs update * Update generated TF resources * Attempt to work around docs linter * Add provision token tests * Remove pipeline_uuid and step_uuid from protos Also, fix deploment_environment_uuid field name. * Remove references to removed fields in tests * Switch to go-oidc/v3 and remove now-redundant nbf check * Fix go.mod imports for the TF provider * Fix event-handler go.mod * Address review feedback; add 15s timeout to fetch provider metadata * Update lib/bitbucket/token_validator.go Co-authored-by: rosstimothy <[email protected]> * Fix build after constant rename --------- Co-authored-by: rosstimothy <[email protected]>
|
@timothyb89 - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
github-actions
bot
requested review from
hugoShaka,
rosstimothy,
strideynet,
tigrato and
zmb3
|
🤖 Vercel preview here: https://docs-442wgmulo-goteleport.vercel.app/docs |
tigrato
approved these changes
Nov 22, 2024
rosstimothy
approved these changes
Nov 22, 2024
public-teleport-github-review-bot
bot
removed request for
zmb3,
strideynet and
hugoShaka
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #48724 for branch/v17
This adds a new
bitbucketjoin method that Machine ID bots can use to authenticate to Teleport from Bitbucket Pipelines CI runs.changelog: Support delegated joining for Bitbucket Pipelines in Machine ID