Respect client_idle_timeout config in kube proxy forwarder #49121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
reviewed
Nov 18, 2024
| @@ -92,7 +92,10 @@ func runPortForwardingWebSocket(req portForwardRequest) error { | |||
| Channels: channels, | |||
| }, | |||
| }) | |||
| conn.SetIdleTimeout(IdleTimeout) | |||
|
|
|||
| if req.idleTimeout != 0 { | |||
There was a problem hiding this comment.
Do we need to protect against setting a timeout of 0?
There was a problem hiding this comment.
I don't really think you need it. I wonder if we should care about a max limit like K8S does of 4h
There was a problem hiding this comment.
@tigrato the max limit is controlled with streamingConnectionIdleTimeout on the teleport's side we use client_idle_timeout. Do you think we need something more?
There was a problem hiding this comment.
@creack what do you mean by streamingConnectionIdleTimeout ?
There was a problem hiding this comment.
The 4h limit in k8s is the default value of the streamingConnectionIdleTimeout kubelet setting
…low for long-running fort forard / exec sessions.
creack
force-pushed
the
creack/fix-kube-fw-idle-timeout
branch
from
9c212cf
to
638d614
Compare
tigrato
approved these changes
Nov 21, 2024
rosstimothy
approved these changes
Nov 21, 2024
This was referenced Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idle timeout was hard-coded to 15 minutes, which prevented people from using long-running port-forward and exec sessions.
Now use the config value.
Changelog: Support for long-running kube exec/port-forward, respect client_idle_timeout config
Fixes #47813