Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Machine ID: Support overriding Proxy address from ProxyPing when using TLS routing #48675

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

strideynet
Copy link
Contributor

Backports #48373
Backports #48667

changelog: Machine ID can now be forced to use the explicitly configured proxy address using the TBOT_USE_PROXY_ADDR environment variable. This should better support split proxy address operation.

…g TLS routing (#48373)

* Start working on ability to use explicit proxy address

* Convert more call-sites to use new helper

* Convert final callsite

* Simplify implementation

* Fix teests

* Remove additional check

* Fix dialling auth client

* Update env var name
)

* Prefer "yes" over "1" for historical consistency

* Try and retrigger the CLA check with an empty commit
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48675.d212ksyjt6y4yg.amplifyapp.com

@strideynet strideynet added this pull request to the merge queue Nov 8, 2024
Merged via the queue into branch/v16 with commit 262e054 Nov 8, 2024
42 checks passed
@strideynet strideynet deleted the strideynet/v16/backport-48373 branch November 8, 2024 16:56
@camscale camscale mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants