Connect: Fix fetching access requests when leaf cluster is selected #48433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzdunek
approved these changes
Nov 5, 2024
avatus
approved these changes
Nov 5, 2024
|
@ravicious See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through the test plan I noticed that if a leaf cluster is selected in the cluster selector, Connect attempts to fetch access requests from that leaf cluster:
access-request-list-bug.mov
I completely removed accessing
localClusterUrifrom that hook as it's not really needed for anything. The bug was introduced in #42533.If you want to test it yourself, you have to cherry-pick those changes on branch/v17. Master is currently bugged and won't give you the option to see the list of requests after successfully submitting one.
access-request-list-fix.mov
changelog: Fixed showing the list of access requests in Teleport Connect when a leaf cluster is selected in the cluster selector