allow admin users generate certs for other users #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizhentas
changed the title
| if req.User != caller { | ||
| // only for themselves, except admin users | ||
| caller, _, ok := r.BasicAuth() | ||
| if !ok || (req.User != caller && s.a.role != teleport.RoleAdmin) { |
There was a problem hiding this comment.
Why not use AuthWithRoles directly instead of a for readability?
On the other note - if there's no BasicAuth in request, the error message will be somewhat dubious:
User cannot request a certificate for foo - with nothing in place of the user name.
|
lgtm apart from a small nitpick |
ibeckermayer
pushed a commit
that referenced
this pull request
Dec 3, 2021
444cf33 simplify connection establishment (#480) gravitational/webapps@444cf33 [source: -w teleport-v8] [target: -t zmb3/desktop-access-backports]
ibeckermayer
pushed a commit
that referenced
this pull request
Dec 3, 2021
444cf33 simplify connection establishment (#480) gravitational/webapps@444cf33 [source: -w teleport-v8] [target: -t master]
ibeckermayer
pushed a commit
that referenced
this pull request
Dec 3, 2021
444cf33 simplify connection establishment (#480) gravitational/webapps@444cf33 [source: -w teleport-v8] [target: -t branch/v8]
zmb3
pushed a commit
that referenced
this pull request
Dec 3, 2021
444cf33 simplify connection establishment (#480) gravitational/webapps@444cf33 [source: -w teleport-v8] [target: -t zmb3/desktop-access-backports]
zmb3
added a commit
that referenced
this pull request
Dec 3, 2021
* Expose endpoint for fetching single desktop (#9041) * updates endpoints * Exposes an endpoint for fetching a single desktop by name * Apply suggestions from code review Co-authored-by: Zac Bergquist <[email protected]> * changes inaccurate desktopUUID to desktopName Co-authored-by: Zac Bergquist <[email protected]> * docs: LDAP service account setup (#8875) * updating docs with service account tutorial * minor corrections * Apply suggestions from code review Co-authored-by: Zac Bergquist <[email protected]> * wording changes based on CR * minor changes and fixes and adds updated photos with new naming convention * Updating documentation * updating gpo instructions to actually make sense * nits * adding instructions for exporting ca * removing unhelpful screen shot * Fixes quotes and updates to LDAPS Co-authored-by: Ben Arent <[email protected]> * clarifying comment Co-authored-by: Zac Bergquist <[email protected]> Co-authored-by: Ben Arent <[email protected]> * Enhance LDAP desktop discovery (#9152) * Refactor component heartbeat callbacks Consolidate the OK/degraded broadcasts so the same logic isn't duplicated for each component. * Periodically update discovered desktops Fixes #8644 * Allow customizing the desktop search With this change, we support a discovery base DN other than '*', and add support for further filtering the results with additional LDAP filters. Additionally, we filter out group managed service accounts, which show up in LDAP searches for (objectClass=computer), despite not being comptuers. (This is mostly harmless, as the service accounts aren't present in DNS, so Teleport just ignores them. It does, however, log a DNS error message that could be confusing, so we explicitly filter these out just to be safe. This was discovered when testing on AWS managed AD, which creates a gMSA for DNS. * simplify connection establishment (#9098) * Adds username and initial screen size to the websocket parameter string and sends over tdp during the connection process * simplifications from CR * fixes // // * Update e ref * Create separate builds for CentOS7 (+fips) Add new buildboxes for centos7 and centos7-fips. For now, we will continue to support both CentOS 6 and 7. Eventually we will drop support for CentOS 6, and the only supported CentOS builds will be these new CentOS 7 builds. Fixes #9028 * [auto] Update webassets in zmb3/desktop-access-backports (#9210) 444cf33 simplify connection establishment (#480) gravitational/webapps@444cf33 [source: -w teleport-v8] [target: -t zmb3/desktop-access-backports] Co-authored-by: Isaiah Becker-Mayer <[email protected]> Co-authored-by: Ben Arent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows admin users generate certs for other users. Regular users are still restricted