Fix UserContext SSO detection in UI for Okta Users #47944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
backport/branch/v14
backport/branch/v15
backport/branch/v16
discover
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
smallinsky
approved these changes
Oct 25, 2024
greedy52
approved these changes
Oct 25, 2024
lib/web/ui/usercontext.go
Outdated
Comment on lines
107
to
108
| isSSO := user.GetUserType() == types.UserTypeSSO || | ||
| len(user.GetOIDCIdentities()) > 0 || |
There was a problem hiding this comment.
looks good to me. just curious if user.GetUserType() is enough without checking other identities?
There was a problem hiding this comment.
It only checks for the CreatedBy.Connector != nil.
I did that, but some tests started failing so I'm not sure we should be changing that.
On the other hard, maybe user.GetUserType() should check not only for the CreatedBy.Connector but also for the OIDC and SAML identities.
There was a problem hiding this comment.
Ended up moving the check to user.GetUserType
I'm pretty confident we could remove the SAML/OIDC checks but playing on the safe side here.
public-teleport-github-review-bot
bot
removed request for
ravicious and
eriktate
Okta imported users are not being properly identified as SSO users. Okta does not set any of the Users' identities and instead only sets the User.Connector.CreatedBy field. When building the UserContext, which is used by the WebUI, it was returning `local` user type for Okta users.
marcoandredinis
force-pushed
the
marco/fix_ui_sso_detection
branch
from
5caea60 to
cc605f4
Compare
|
@marcoandredinis See the table below for backport results.
|
This was referenced Oct 25, 2024
marcoandredinis
added a commit
that referenced
this pull request
Oct 25, 2024
* Fix UserContext SSO detection in UI for Okta Users Okta imported users are not being properly identified as SSO users. Okta does not set any of the Users' identities and instead only sets the User.Connector.CreatedBy field. When building the UserContext, which is used by the WebUI, it was returning `local` user type for Okta users. * move usertype check to types.User
marcoandredinis
added a commit
that referenced
this pull request
Oct 28, 2024
* Fix UserContext SSO detection in UI for Okta Users Okta imported users are not being properly identified as SSO users. Okta does not set any of the Users' identities and instead only sets the User.Connector.CreatedBy field. When building the UserContext, which is used by the WebUI, it was returning `local` user type for Okta users. * move usertype check to types.User
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
…7959) * Fix UserContext SSO detection in UI for Okta Users (#47944) * Fix UserContext SSO detection in UI for Okta Users Okta imported users are not being properly identified as SSO users. Okta does not set any of the Users' identities and instead only sets the User.Connector.CreatedBy field. When building the UserContext, which is used by the WebUI, it was returning `local` user type for Okta users. * move usertype check to types.User * remove User.Status field which only exists on 15+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okta imported users are not being properly identified as SSO users. Okta does not set any of the Users' identities and instead only sets the User.Connector.CreatedBy field.
When building the UserContext, which is used by the WebUI, it was returning
localuser type for Okta users.As an example of what this fixes in the UI: when setting traits during the Discover flows, User is now correctly asked to change the Teleport Role instead of being allowed to enter principals but then getting an error.
Before
After
Fixes #47901
changelog: During the Set Up Access of the Enroll New Resource flows, Okta users will be asked to change the role instead of entering the principals and getting an error afterwards.