Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Identity Center plugin type constants #47792

Closed
wants to merge 2 commits into from
Closed

Adds Identity Center plugin type constants #47792

wants to merge 2 commits into from

Conversation

tcsc
Copy link
Contributor

@tcsc tcsc commented Oct 22, 2024

No description provided.

@tcsc tcsc added the no-changelog Indicates that a PR does not require a changelog entry label Oct 22, 2024
@tcsc tcsc requested a review from smallinsky October 22, 2024 11:27
@tcsc tcsc changed the base branch from tcsc/idc-servic-role to master October 23, 2024 01:52
@tcsc tcsc changed the base branch from master to tcsc/idc-servic-role October 23, 2024 01:57
flyinghermit
flyinghermit requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@flyinghermit flyinghermit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I have a plugin PR that is almost ready and that includes this.

api/types/plugin.go Outdated Show resolved Hide resolved
@tcsc @flyinghermit
Update api/types/plugin.go
279d466 
Co-authored-by: Sakshyam Shah <[email protected]>
@tcsc
Copy link
Contributor Author

tcsc commented Oct 23, 2024

FYI, I have a plugin PR that is almost ready and that includes this.

Link me when its up, and I will close this in favour of yours

@flyinghermit
Copy link
Contributor

@tcsc just opened #47844 few minutes ago and tagged you for review :)

@tcsc
Copy link
Contributor Author

tcsc commented Oct 23, 2024 •
edited
Loading

Closed in favour of #47844

@tcsc tcsc closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyinghermit flyinghermit flyinghermit requested changes

@r0mant r0mant r0mant approved these changes

@bernardjkim bernardjkim bernardjkim approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcsc @flyinghermit @r0mant @bernardjkim