[v14] fix: Avoid needless user escalation during auto-enroll #47697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
commented
Oct 18, 2024
| ) | ||
|
|
||
| // AutoEnrollCeremony is the auto-enrollment version of [Ceremony]. | ||
| type AutoEnrollCeremony struct { | ||
| *Ceremony | ||
|
|
||
| CollectDeviceData func() (*devicepb.DeviceCollectedData, error) |
There was a problem hiding this comment.
Not sure what got git confused, looks exactly the same to me. o.O
github-actions
bot
requested review from
rosstimothy,
strideynet,
tigrato and
timothyb89
tigrato
approved these changes
Oct 18, 2024
rosstimothy
approved these changes
Oct 18, 2024
public-teleport-github-review-bot
bot
removed request for
timothyb89 and
strideynet
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #47676 to branch/v14.
changelog: Avoid tsh auto-enroll escalation in machines without a TPM