[access-graph] extract S3 bucket tags #45364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR extracts the AWS bucket tags by calling `GetBucketTagging`. Part of gravitational/access-graph#898 Signed-off-by: Tiago Silva <[email protected]>
tigrato
added
backport/branch/v14
no-changelog
github-actions
bot
requested review from
camscale,
codingllama,
mmcallister,
ptgott,
r0mant,
xinding33 and
zmb3
|
🤖 Vercel preview here: https://docs-4xvesp8lp-goteleport.vercel.app/docs/ver/preview |
ptgott
approved these changes
Aug 12, 2024
zmb3
reviewed
Aug 12, 2024
| @@ -155,6 +155,7 @@ The IAM policy includes the following directives: | |||
| "s3:GetBucketPolicy", | |||
| "s3:ListBucket", | |||
| "s3:GetBucketLocation", | |||
| "s3:GetBucketTagging", | |||
There was a problem hiding this comment.
The changelog should probably mention something about this new requirement, otherwise self-hosted users won't know they need to update their permissions.
There was a problem hiding this comment.
I don't think this is yet being used but added a note to changelog.
codingllama
reviewed
Aug 12, 2024
| @@ -107,8 +109,22 @@ func (a *awsFetcher) fetchS3Buckets(ctx context.Context) ([]*accessgraphv1alpha. | |||
| if err != nil { | |||
| collect(nil, trace.Wrap(err, "failed to fetch bucket %q acls policies", aws.ToString(bucket.Name))) | |||
| } | |||
|
|
|||
| tagsOutput, err := s3Client.GetBucketTaggingWithContext(ctx, &s3.GetBucketTaggingInput{ | |||
tigrato
removed
the
no-changelog
|
🤖 Vercel preview here: https://docs-lgomb5eb4-goteleport.vercel.app/docs/ver/preview |
codingllama
reviewed
Aug 13, 2024
|
🤖 Vercel preview here: https://docs-9sk0xmmp5-goteleport.vercel.app/docs/ver/preview |
codingllama
approved these changes
Aug 14, 2024
marcoandredinis
approved these changes
Aug 16, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant,
mmcallister,
xinding33 and
camscale
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the AWS bucket tags by calling
GetBucketTagging.Part of https://github.com/gravitational/access-graph/issues/898
Changelog: Added support for importing S3 Bucket Tags into Teleport Policy's Access Graph. For existing configurations, ensure that the
s3:GetBucketTaggingpermission is manually included in the Teleport Access Graph integration role.