[buddy] Truncate AssumeRole session name to API limits #45202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: STeve (Xin) Huang <[email protected]>
codingllama
reviewed
Aug 7, 2024
lib/utils/aws/credentials.go
Outdated
| @@ -74,7 +74,7 @@ func (g *credentialsGetter) Get(_ context.Context, request GetCredentialsRequest | |||
| logrus.Debugf("Creating STS session %q for %q.", request.SessionName, request.RoleARN) | |||
| return stscreds.NewCredentials(request.Provider, request.RoleARN, | |||
| func(cred *stscreds.AssumeRoleProvider) { | |||
| cred.RoleSessionName = request.SessionName | |||
| cred.RoleSessionName = TruncateRoleSessionName(request.SessionName) | |||
There was a problem hiding this comment.
Same remark about clashes here.
smallinsky
approved these changes
Aug 13, 2024
lib/utils/aws/aws.go
Outdated
|
|
||
| // MaxRoleSessionName is the maximum length of the role session name used by the AssumeRole call. | ||
| // https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_iam-quotas.html | ||
| MaxRoleSessionName = 64 |
There was a problem hiding this comment.
nit: just to make it explicit that this is not count but name length.
Suggested change
| MaxRoleSessionName = 64 | |
| MaxRoleSessionNameLength = 64 |
| @@ -2745,6 +2745,13 @@ message AppSessionStart { | |||
| (gogoproto.embed) = true, | |||
| (gogoproto.jsontag) = "" | |||
| ]; | |||
|
|
|||
| // AWS contains common AWS session information. | |||
| AWSSessionMetadata AWS = 9 [ | |||
There was a problem hiding this comment.
Can we make it more generic like
Suggested change
| AWSSessionMetadata AWS = 9 [ | |
| AWSMetadata AWS = 9 [ |
I wonder what other fields can be added to AWSSessionMetadata, where AWSMetadata would be more flexible and in the case of other AWS fields not related to AWSSession context I think that the AWSMetadata it will be a better fit.
codingllama
reviewed
Aug 13, 2024
I feel the same but it's not an easy fix. I decided to drop the audit from the PR and make the fix separately. Another issue with current design (how the session event is sent) is the event happens on the root but not on the leaf. -- update |
codingllama
approved these changes
Aug 19, 2024
public-teleport-github-review-bot
bot
removed request for
gabrielcorado and
rudream
marcoandredinis
approved these changes
Aug 20, 2024
greedy52
added a commit
that referenced
this pull request
Aug 21, 2024
* 44833 Truncate AssumeRole session name to API limits * Link reference Co-authored-by: STeve (Xin) Huang <[email protected]> * Hash the username and add audit log * review comments * remove audit --------- Co-authored-by: Joao Ubaldo <[email protected]>
greedy52
added a commit
that referenced
this pull request
Aug 21, 2024
* 44833 Truncate AssumeRole session name to API limits * Link reference Co-authored-by: STeve (Xin) Huang <[email protected]> * Hash the username and add audit log * review comments * remove audit --------- Co-authored-by: Joao Ubaldo <[email protected]>
greedy52
added a commit
that referenced
this pull request
Aug 21, 2024
* 44833 Truncate AssumeRole session name to API limits * Link reference Co-authored-by: STeve (Xin) Huang <[email protected]> * Hash the username and add audit log * review comments * remove audit --------- Co-authored-by: Joao Ubaldo <[email protected]>
This was referenced Aug 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
* [buddy] Truncate AssumeRole session name to API limits (#45202) * 44833 Truncate AssumeRole session name to API limits * Link reference Co-authored-by: STeve (Xin) Huang <[email protected]> * Hash the username and add audit log * review comments * remove audit --------- Co-authored-by: Joao Ubaldo <[email protected]> * reintroduce logrus --------- Co-authored-by: Joao Ubaldo <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
* 44833 Truncate AssumeRole session name to API limits * Link reference * Hash the username and add audit log * review comments * remove audit --------- Co-authored-by: Joao Ubaldo <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
* 44833 Truncate AssumeRole session name to API limits * Link reference * Hash the username and add audit log * review comments * remove audit --------- Co-authored-by: Joao Ubaldo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44833
buddy PR:
changelog: Fixed an issue AWS access fails when the username is longer than 64 characters