[branch/v15] Invoke signing function for Windows Connect binary (#41963) #44420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
reviewed
Jul 19, 2024
build.assets/windows/build.ps1
Outdated
| return "$SignedBinaryPath" # This is needed for building Connect and bundling the zip archive | ||
| } | ||
|
|
||
| function Build-Tctl { |
There was a problem hiding this comment.
We only ship tctl for Windows in v16+
There was a problem hiding this comment.
I screwed up the git command for the backport. This should be fixed
zmb3
approved these changes
Jul 19, 2024
gzdunek
approved these changes
Jul 22, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ravicious
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #41963
changelog: Fixed Teleport Connect binaries not being signed correctly.