[v14] Disable session recording for non-interactive sessions #42321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/backport-41991/v14
branch
from
e54c7b0
to
403c39f
Compare
These recordings only contain session.start, session.end and session.leave events, all of which are already included in the audit log. Removing these recordings should produce no data loss but will greatly reduce the amount of work performed by the agents, the auth service, and storage costs. The only case where non-interactive sessions are still recording is when BPF is enabled. This is required, for now, because enhanced session recording can generate more events than the audit log has traditionally been able to ingest.
rosstimothy
force-pushed
the
tross/backport-41991/v14
branch
from
403c39f
to
fe35d0e
Compare
github-actions
bot
added
audit-log
marcoandredinis
approved these changes
Jun 4, 2024
ravicious
approved these changes
Jun 4, 2024
public-teleport-github-review-bot
bot
removed the request for review
from camscale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #41991 to branch/v14
changelog: Disabled session recordings for non-interactive sessions when enhanced recording is disabled. There is no loss of auditing or impact on data fidelity because these recordings only contained session.start, session.end, and session.leave events which were already captured in the audit log. This will cause all teleport components to consume less resources and reduce storage costs.