-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the style rule for Teleport editions #42025
Conversation
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Context: #41285 (comment) |
Honestly I still kinda think this is confusing. Saying "cloud-hosted Teleport Enterprise" doesn't really make a distinction between:
Both are technically cloud-hosted Teleport Enterprise, but our SaaS has a few more arbitrary limitations such as #42060 "Teleport Enterprise Cloud" did, at the least, have a name that was distinct enough to discern SaaS from non-SaaS. |
@webvictim Would it make more sense to say "managed Teleport Enterprise" in the docs instead of "cloud-hosted"? |
Yeah, that sounds much better! |
b5c5e7b
to
f84d4f3
Compare
Encourage authors to take a more flexible approach to mentioning cloud-hosted and self-hosted Teleport Enterprise. In the current vale style rule for Teleport editions, the alternative to "Teleport Enterprise Cloud" seemed to be a more rigid suggestion to use "Teleport Enterprise (cloud-hosted)", which is usually not the smoothest way to express this information.
f84d4f3
to
f2df0d8
Compare
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
1 similar comment
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Encourage authors to take a more flexible approach to mentioning cloud-hosted and self-hosted Teleport Enterprise. In the current vale style rule for Teleport editions, the alternative to "Teleport Enterprise Cloud" seemed to be a more rigid suggestion to use "Teleport Enterprise (cloud-hosted)", which is usually not the smoothest way to express this information.