Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker dir #41369

Merged
merged 3 commits into from
May 9, 2024
Merged

Remove docker dir #41369

merged 3 commits into from
May 9, 2024

Conversation

mcbattirola
Copy link
Contributor

@mcbattirola mcbattirola commented May 9, 2024

I noticed while working on another task that the makefile in this directory references licenses that don't work properly anymore.

Asking around, it seems no one uses it anymore.

I think this can be removed, as it was last touched 2 years ago and I couldn't find any Make target or script referencing these files.

@mcbattirola mcbattirola marked this pull request as ready for review May 9, 2024 15:39
@github-actions github-actions bot requested review from GavinFrazar and ravicious May 9, 2024 15:40
Copy link

github-actions bot commented May 9, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@mcbattirola mcbattirola added the no-changelog Indicates that a PR does not require a changelog entry label May 9, 2024
Copy link
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mcbattirola mcbattirola added this pull request to the merge queue May 9, 2024
Merged via the queue into master with commit 02e899b May 9, 2024
38 of 39 checks passed
@mcbattirola mcbattirola deleted the mcbattirola/remove-docker-dir branch May 9, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants