Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v15] Fail when JS test uses console.error or console.warn #41367

Merged
merged 4 commits into from
May 14, 2024
Merged

[v15] Fail when JS test uses console.error or console.warn #41367

merged 4 commits into from
May 14, 2024

Conversation

ravicious
Copy link
Member

@ravicious ravicious commented May 9, 2024 •
edited
Loading

@ravicious ravicious added the no-changelog Indicates that a PR does not require a changelog entry label May 9, 2024
@github-actions github-actions bot requested review from gzdunek and kimlisa May 9, 2024 15:28
@kimlisa
Copy link
Contributor

kimlisa commented May 9, 2024

@ravicious do you mind combining this with this PR: #41390 (comment)

@ravicious ravicious mentioned this pull request May 14, 2024
Merged
@ravicious ravicious added this pull request to the merge queue May 14, 2024
Merged via the queue into branch/v15 with commit 7a0760f May 14, 2024
32 checks passed
@ravicious ravicious deleted the bot/backport-41252-branch/v15 branch May 14, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimlisa kimlisa kimlisa approved these changes

@gzdunek gzdunek gzdunek approved these changes

Assignees
No one assigned
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravicious @kimlisa @gzdunek